Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for richInspectVariables request #654

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Added documentation for richInspectVariables request #654

merged 3 commits into from
Jun 7, 2021

Conversation

JohanMabille
Copy link
Member

@JohanMabille JohanMabille commented Jun 4, 2021 •
edited
Loading

This PR adds documentation for a new debug requets in the protocol.

Carreau
Carreau approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing quote, and I believe double backticks, I'll commit directly the changes to your branch, let me know if I was wrong, +1 to merge once CI gree.

docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
docs/messaging.rst Outdated Show resolved Hide resolved
@JohanMabille
Copy link
Member Author

Hold on, I have a slight change to push.

@davidbrochart
Copy link
Member

Double backticks are still missing for inspectVariables, debugInfo and dumpCell, but that can be done in a separate PR.

@Carreau Carreau merged commit afc5b38 into jupyter:master Jun 7, 2021
@JohanMabille JohanMabille deleted the rich_inspect_variable branch June 7, 2021 23:27
@blink1073 blink1073 added this to the 7.0 milestone Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@JohanMabille @davidbrochart @Carreau @blink1073