Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 7.0] Remove deprecations in kernel manager #643

Merged
merged 2 commits into from
Apr 13, 2021
Merged

[Release 7.0] Remove deprecations in kernel manager #643

merged 2 commits into from
Apr 13, 2021

Conversation

kevin-bates
Copy link
Member

This change removes the 7-year deprecation of the kernel_cmd trait and last year's deprecation of the cleanup() method which was replaced with cleanup_resources().

This is part of #642.

@blink1073 blink1073 added this to the 7.0 milestone Apr 13, 2021
blink1073
blink1073 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 3515e89 into jupyter:master Apr 13, 2021
@kevin-bates kevin-bates deleted the remove-deprecations branch April 13, 2021 14:13
@kevin-bates kevin-bates mentioned this pull request Apr 13, 2021
Closed
14 tasks
@kevin-bates kevin-bates mentioned this pull request Apr 30, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin-bates @blink1073 @davidbrochart