Silence kill_kernel when no process is present #576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a kernel's shutdown, a race condition can occur between the kernel manager and the kernel restarter such that the restarter sees the kernel process has terminated, yet it's view of the kernel manager still thinks its managing an instance. In such cases, the restarter initiates its restart sequence and, when attempting to kill the kernel, finds that there's now no kernel process being managed. In such conditions, the kernel manager was raising an exception indicating there's no process to kill. Instead, it should perform the same action as when there is a process to kill, only to have the signaling fail because there is no longer any process - which is to ignore that condition. This change essentially ignores the case when a final kill request (i.e.,
SIGKILL
vs.SIGTERM
) finds that a process is no longer being managed (i.e.,self.has_kernel is None
).Fixes #575