Document the handling of error in do_execute #500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My customized kernel does something like the following to handle errors
which works fine during interactive data analysis or through
Run all cells
. However, papermill does not recognizes the error and returns0
when it converts notebooks with my kernel. It turns out that a message of typeerror
should be sent throughself.send_response
in addition to returningexecute_reply
withstatus
oferror
. Although I believe the caller of thisdo_execute
function should automatically do this, this PR documents the proper way of handling errors in this function, namely