Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import warnings for 5.2.x #343

Merged
merged 1 commit into from
Jan 28, 2018
Merged

import warnings for 5.2.x #343

merged 1 commit into from
Jan 28, 2018

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Jan 27, 2018

This might need to be targeted on 5.x. We were running into an issue where a warning was being issued without import warnings being done at the top.

@rgbkrk rgbkrk changed the base branch from 5.2.x to 5.x January 27, 2018 21:10
@rgbkrk
Copy link
Member Author

rgbkrk commented Jan 27, 2018

Switched the base branch to 5.x.

@takluyver
Copy link
Member

Thanks, makes sense.

@takluyver takluyver merged commit 9c31adf into jupyter:5.x Jan 28, 2018
@rgbkrk rgbkrk deleted the add-missing-warnings branch January 28, 2018 18:52
@minrk minrk added this to the 5.2.3 milestone Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@rgbkrk @takluyver @minrk