add a jlpm
"bootstrap" entrypoint that can run during eg pip install of jupyterlab
#105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that we can't reliably execute
jlpm
during the javascript install steps of eg a pip development install ofjupyterlab
causes some pain currently. It will cause more pain and real problems when we migratejupyterlab
to yarn v2.x+ (see: jupyterlab/jupyterlab#10929). If we include a "bootstrap" version of thejlpm
entrypoint that installs as part ofjupyterlab_packaging
this problem goes away.jupyterlab_packaging
will only ever get installed transiently in a pip (or whatever py build tool) build env, and said install will only exist as long as the build is running. So in theory, at the end of ajupyterlab
build thejlpm
provided byjupyterlab_packaging
will just gracefully evaporate and be replace by thejlpm
provided byjupyterlab
itself. We'll see how that works out in practice