Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a jlpm "bootstrap" entrypoint that can run during eg pip install of jupyterlab #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

telamonian
Copy link

The fact that we can't reliably execute jlpm during the javascript install steps of eg a pip development install of jupyterlab causes some pain currently. It will cause more pain and real problems when we migrate jupyterlab to yarn v2.x+ (see: jupyterlab/jupyterlab#10929). If we include a "bootstrap" version of the jlpm entrypoint that installs as part of jupyterlab_packaging this problem goes away.

jupyterlab_packaging will only ever get installed transiently in a pip (or whatever py build tool) build env, and said install will only exist as long as the build is running. So in theory, at the end of a jupyterlab build the jlpm provided by jupyterlab_packaging will just gracefully evaporate and be replace by the jlpm provided by jupyterlab itself. We'll see how that works out in practice

@telamonian
Copy link
Author

telamonian commented Sep 8, 2021

pinging @jtpio @blink1073. If anyone can give me explicit instructions on how to test these changes as part of eg pip install -e ./jupyterlab, that would be super helpful

nm, I figured it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant