Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing links in JMS charter #231

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Conversation

andrii-i
Copy link
Contributor

No description provided.

Copy link
Member

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one minor typo correction. Can we get the JMS council to approve this change (i.e., officially codifying the url that is maintained for the policies)?

@blink1073
Copy link
Contributor

Merging, since all of us have approved.

@blink1073 blink1073 merged commit 0d47b0e into jupyter:main Jun 28, 2024
1 check passed
@andrii-i andrii-i deleted the fix-charter branch June 28, 2024 19:06
@andrii-i
Copy link
Contributor Author

andrii-i commented Jul 9, 2024

@jupyter/executive-council could you please give this PR a look and potentially approval? This PR adds missing links and was merged without explicit approval of EC. Are these changes OK or should it be reverted (see PR #232)?

@jasongrout
Copy link
Member

We discussed this in a recent meeting. Eventually we should set permissions on this repo so that only the EC and SSC can merge, but for situations like this:

  1. The voting members of the working group or standing committee must approve the change (done here)
  2. For small or unsubstantial changes to a working group/standing committee charter, any member of the EC can merge. For larger changes then they should notify the EC and ask for review. I think this falls under the "small changes" case. While Steve did the actual merging, Ana and I did approve the change here, so I think we are good.

@andrii-i
Copy link
Contributor Author

andrii-i commented Jul 9, 2024

Thank you @jasongrout.

@Ruv7
Copy link
Contributor

Ruv7 commented Jul 10, 2024

I think we're set on this particular change from the JMS. Thanks all for the work here.

Since this request will set precedent moving forward I do want to clarify that regardless of the merge rights on this repo, the intent here is that Working Group and Standing Committees consult with the EC for changes to their charters. If an EC member is also a member of the WG/SC they should not be the one to merge the change.

I want to take out the description large and small changes because even small changes - for example increasing a number from 1 to 2 or making a word plural instead of singular can be a substantive when it comes to a charter doc.

Process for changing charter

  1. The voting members of the working group or standing committee approve the change

  2. Notify the EC and request review. For changes that are not substantive, any member of the EC can merge. For changes that land in a grey area or are deemed substantive, the EC may request further info or discussion from the group.

@jasongrout
Copy link
Member

Also, let's write this process down somewhere on the EC team compass.

@Ruv7
Copy link
Contributor

Ruv7 commented Jul 10, 2024

Also, let's write this process down somewhere on the EC team compass.

Agree, this should be documented. I'm not sure where it should go, perhaps in the Governance Docs? I think people who are looking for how to's are more likely to go there than the EC Team Compass. I'm can own the next steps on figuring that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants