-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing links in JMS charter #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one minor typo correction. Can we get the JMS council to approve this change (i.e., officially codifying the url that is maintained for the policies)?
Co-authored-by: Jason Grout <[email protected]>
Merging, since all of us have approved. |
@jupyter/executive-council could you please give this PR a look and potentially approval? This PR adds missing links and was merged without explicit approval of EC. Are these changes OK or should it be reverted (see PR #232)? |
We discussed this in a recent meeting. Eventually we should set permissions on this repo so that only the EC and SSC can merge, but for situations like this:
|
Thank you @jasongrout. |
I think we're set on this particular change from the JMS. Thanks all for the work here. Since this request will set precedent moving forward I do want to clarify that regardless of the merge rights on this repo, the intent here is that Working Group and Standing Committees consult with the EC for changes to their charters. If an EC member is also a member of the WG/SC they should not be the one to merge the change. I want to take out the description large and small changes because even small changes - for example increasing a number from 1 to 2 or making a word plural instead of singular can be a substantive when it comes to a charter doc. Process for changing charter
|
Also, let's write this process down somewhere on the EC team compass. |
Agree, this should be documented. I'm not sure where it should go, perhaps in the Governance Docs? I think people who are looking for how to's are more likely to go there than the EC Team Compass. I'm can own the next steps on figuring that out. |
No description provided.