Jupyter Notebook Deprecation Notice

[romainx]

Hello,

This is a very first step of the feature #1217 that consists in printing a deprecation notice in the start-notebook.sh.

Here is the new behavior

• With no option (no specific environment variable): Jupyter Notebook is launched (no change). However a warning message is printed pointing to https://github.com/jupyter/notebook#notice.
• With JUPYTER_ENABLE_LAB: Jupyter Lab is launched (no change).

I've written a test that checks this behavior.

Best

[romainx]

@parente could you please share your opinion? I'd like to make sure I'm in the right direction before I go any further and spend more time updating the documentation. Thanks 😄

[Bidek56]

JupyterLab may be popular but I feel it's a giant web app which sucks up a lot of browser resources, hence I stay away from.
Notebook is much closer to other platforms like Databricks or Colab.
If we do end up defaulting to it, please add some docs on how to un-default it. :) Thanks

[3j14]

I added some documentation on your personal fork @romainx.

I understand @Bidek56's concerns and I was also thinking that changing the default behavior might result in confusion. But if the old notebook frontend is actually going to be deprecated and to be replaced with jupyterlab-classic, this change will have to come anyway. It might be beneficial to separate some of the documentation for Docker images from before and after the JupyterLab 3.0 transition to avoid confusion.

[romainx]

@jnsdrtlf thank you very much and sorry for not taking the time to look at your contribution. I will do it for sure 😄 . I am waiting for feedback before going any further because I do not have enough knowledge to identify the possible impacts of such a change.

[3j14]

@romainx no worries, this (and the transition to JupyterLab 3.0) is a huge change and should not be rushed. While the documentation clearly states that you should always use a tagged version, I can imagine that people tend to use latest even in production environments. This could cause a lot of headaches.

[romainx]

@parente I've implement the changes and now this deprecation stream is followed in a dedicated issue #1217.

[mathbunnyru]

Good job keeping up with Jupyter changes, @romainx 👍

[parente]

I left a couple more wording suggestions for the README as did @mathbunnyru. Thanks for working on this @romainx and being thoughtful about the community of people who use these images.

[romainx]

@parente and @mathbunnyru thanks a lot for your help and advices.
Really appreciate working with you guys ❤️.
I will merge it 🎉 .

[mathbunnyru]

@parente and @mathbunnyru thanks a lot for your help and advices.
Really appreciate working with you guys ❤️.
I will merge it 🎉 .

Parce que vous êtes de Toulouse, je pense que vous parlez français bien et je viens de répondre en français.
Désolé pour les erreurs 😂
Merci à vous pour tous les efforts que vous donnes aux images 👍
J'aime bien aussi travailler avec vous 🤗

[romainx]

@mathbunnyru you're right and your french is better than my english 🤣 .
Thanks for the message.

[willingc]

@parente I'm not sure that April 2021 gives enough time for folks to adjust to this change. It will likely break anyone who hasn't pinned to a SHA.