-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2020-12-27 #1206
Update 2020-12-27 #1206
Conversation
According to the JupyterLab changelog
I'm wondering if we should remove all the old way of installing extensions in docker-stacks/scipy-notebook/Dockerfile Lines 50 to 59 in d113a60
And if we should merge this PR by dropping the support of the extensions that are not working at the moment or if we should wait until their availability ? A compliance table is given here jupyterlab/jupyterlab#9461. |
Waiting for extensions compat
This PR has been modified to rollback to JupyterLab |
Need to check with the last update from @mirekphd in #1205 before merging. Turned back this PR into draft. I will take the time to check it (currently I do not have so much time, I will probably do it next week at the latest). |
Hello, I've verified and added a basic test to check extensions (we will see how it behaves with JupyterLab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 I left one comment about lab 3.0 and one suggestion inline. I'm pro-actively approving so you can merge when you feel it's ready.
Thanks as always for keeping the images fresh and responding to community questions.
Co-authored-by: Peter Parente <[email protected]>
Pretty sure they will both read jupyter_config.json/py
|
The JupyterLab version has been kept in
2.2.x
since important changes have been made starting at the version3.0.0
on the way to manage extensions, see the JupyterLab Changelog. The result is that some of the extensions installed inscipy-notebook
are not yet compliant. This issue summarizes in a table the extensions currently compliant with the new version.The upgrade to JupyterLab
3.0.x
is detailed in an issue #1207. However a change has been made in order to prepare this migration #1205 and to help users who want to perform the upgrade by themselves to do so.The following changes have been made.
base-notebook
Changed
: Bumpnotebook
Changed
: Bumpjupyterhub
Added
: Created a new configuration filejupyter_server_config.py
in order to prepare the migration to JupyterLab3.0.0
, see also the documentation Migrating from Notebook Server explaining this change -> fixes [base-notebook] Cannot connect to server after upgrading to Jupyter Lab 3.0.0 #1205scipy-notebook
Changed
: Bumpdask
Changed
: Bumpipywidgets
Changed
: Bumpnumba
Changed
: Bumpprotobuf
Changed
: Bumpscikit-image
Changed
: Bumpscikit-learn
Added
: A test to perform a check on each extensionjupyter labextension check
.r-notebook
Changed
: Bumpr-rmarkdown
tensorflow-notebook
Changed
: Bumptensorflow
datascience-notebook
Changed
: Bumpr-rmarkdown