This repository has been archived by the owner on Oct 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
[Issue 23] Support Declarative Widgets #62
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ddf2e53
WIP: Support Declarative Widgets
jhpedemonte b4f9123
Use `IPython` global if it already exists
jhpedemonte 060507c
Need to pass `metadata` as `data` when creating comm
jhpedemonte bca782c
New location for DeclWidgets' bower_components
jhpedemonte bd86511
Additional DeclWidgets shims
jhpedemonte 4da7bf7
Install DeclWidgets inside KG Docker container
jhpedemonte 9fc09a7
Install official declwidgets release
jhpedemonte f731d8d
Install declwidgets in Makefile
jhpedemonte ec2ed43
Pull/build declwidgets in Dockerfile.server
jhpedemonte 0d2993f
Don't build dev-image for declwidgets
jhpedemonte d7ed59d
Add 2 declwidgets examples
jhpedemonte a15ddca
Fix some Makefile dep issues
jhpedemonte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,8 @@ | ||
bower_components/ | ||
certs/ | ||
data/decl-widgets-taxi-demo.ipynb | ||
ext/ | ||
node_modules/ | ||
public/components/ | ||
public/css/ | ||
certs/ | ||
public/urth_components/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add this to
.PHONY
else it does nothing because the directory examples exists. (Or just move to etc/notebooks per other comment and then it'll work fine.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Need to run
gulp build
beforemake examples
. Probably add todev-install
target.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to just make sure that
public/urth_components
exists before doing bower install of Polymer elements.