-
Notifications
You must be signed in to change notification settings - Fork 48
Load declwidgets init code from bundled dashboard #133
Comments
Paired with @parente and found out that some examples work fine with the non-shimmed declwidgets, while still showing many errors in the console. But this led us to notice that we are pulling declwidgets resources from 2 areas: (1) the Polymer elements in Instead, the server should load the init code scripts from the bundle as well. It turns out that the bundler already provides these, in the Re-purposing this issue to track the correct loading of declwidgets resources. |
Redo our bundled dashboards examples Ref jupyter#133 (c) Copyright IBM Corp. 2016
Uploaded PR which makes it so we load the DeclWidgets init scripts from the bundle, rather than supplying our own. Of course, this horribly breaks the use of declwidgets, since that code base needs to be updated as well. |
Did you mean to open a PR? |
Move main Notebook shim function to dashboards.js Ref jupyter#133 (c) Copyright IBM Corp. 2016
Updated to use newer DeclWidgets init API from jupyter/declarativewidgets#251. |
Redo our bundled dashboards examples Ref jupyter#133 (c) Copyright IBM Corp. 2016
Move main Notebook shim function to dashboards.js Ref jupyter#133 (c) Copyright IBM Corp. 2016
Remove refs to 'IPython' (except for single backwards compat line). Remove redundant shim code and clean up. Ref jupyter#133 (c) Copyright IBM Corp. 2016
Need to setup base shims before creating widget mgr. Fix travis build Ref jupyter#133 (c) Copyright IBM Corp. 2016
Fixes issue where declwidgets python code would try to run before declwidgets had finished initializing Ref jupyter#133 (c) Copyright IBM Corp. 2016
Closed by #136. |
Load all declwidgets resources from the bundle. See the first comment below for more information.
Tasks:
init.js
andDeclWidgetsModel.js
from bundle.urth-widgets.js
any more. Remove cloning of declwidgets repo.Previous description:
In our Dockerfile.server we're currently relying on https://github.com/jhpedemonte/declarativewidgets.git@9f6423bbcc4e9e266a8c2594028caeabaebe9a8f in lieu of jupyter/declarativewidgets#196 getting fixed. This suggests to me that no deploys from a stable declarative widgets release should work. But they did/do when I test withmake dev-with-dashboard-server
in dashboards_bundlers.However, when I use a simple docker-compose recipe that installs all stable versions of the jupyter Python packages, sure enough, the errors that @jhpedemonte 's branch is meant to fix shine through.I'm missing something ...At any rate, we need to first understand what's going on and then, over time, drive the decl widget changes to ensure they work both in the notebook and outside.The text was updated successfully, but these errors were encountered: