Skip to content
This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

Fix progress bar (and other styling) #10

Closed
4 tasks done
jhpedemonte opened this issue Jan 12, 2016 · 14 comments
Closed
4 tasks done

Fix progress bar (and other styling) #10

jhpedemonte opened this issue Jan 12, 2016 · 14 comments
Assignees
Milestone

Comments

@jhpedemonte
Copy link
Collaborator

Fix styling issues:

  • Busy indicator appears at bottom of page, doesn't animate and doesn't disappear.
  • Font sizes are different than dashboard in Notebook.
  • Stream message outputs get appended as new elements in output area
    • When phosphor-widget is updated to 1.0.0-rc1 or later, re-commit 94d734d.
  • Output area overlaps widget area, but only when running from Docker container (not from localhost).
jhpedemonte added a commit that referenced this issue Jan 13, 2016
Refs #10

(c) Copyright IBM Corp. 2016
dalogsdon referenced this issue Jan 13, 2016
(c) Copyright IBM Corp. 2016
jhpedemonte added a commit that referenced this issue Jan 13, 2016
Refs #10

🐷

(c) Copyright IBM Corp. 2016
@dalogsdon
Copy link
Contributor

All obvious styling differences seen with the simple dashboard have been fixed. As we add more widget support we will continue to fix styling discrepancies.

@jhpedemonte
Copy link
Collaborator Author

Our fix for the output area didn't work correctly because of an issue in the phosphor-widget dependency. Need to wait for its latest code to be tagged. For now, we've backed out that fix (94d734d).

@parente parente modified the milestone: 0.1.0 Jan 18, 2016
@parente
Copy link
Member

parente commented Jan 25, 2016

@sccolbert @blink1073 Any idea when you might cut RC1 of phosphor-widget?

@sccolbert
Copy link

@parente I can cut an rc.1 at any time, but there have been no functional changes since rc.0. Are you needing something specific?

@dalogsdon
Copy link
Contributor

@blink1073
Copy link

That config does not affect Webpack.

@sccolbert
Copy link

@dalogsdon As Steve said, that package setting only affects the browserify CSS transform. It has no bearing on webpack. Are you seeing something which doesn't work with the rc.0?

@blink1073
Copy link

Ah, you're using Browserify, I was confused by the Webpack file.

@blink1073
Copy link

They're using a separate transform step in gulp, looks like the browserify config interferes with it.

@sccolbert
Copy link

Ah. Yet another reason to not use browserify :)

edit: some tools require that package setting, other tools break with that setting.

@sccolbert
Copy link

The rc.1 is now published.

@dalogsdon
Copy link
Contributor

@blink1073 We are using both browserify and webpack at the moment, and yes it was interfering and causing an error which I don't have handy at the moment.

@sccolbert Thanks for the rc.1, we'll give it another go now.

jhpedemonte added a commit to jhpedemonte/dashboards_server that referenced this issue Jan 28, 2016
Prevents slight shifting of content on initial load.

Ref jupyter#10

(c) Copyright IBM Corp. 2016
@jhpedemonte
Copy link
Collaborator Author

Overlap in dashboard seems to be related to lodash version, somehow! No overlap with v3.5.0, but yes with v4.1.0.

Ah. Known issue in Gridstack: gridstack/gridstack.js#307

@parente
Copy link
Member

parente commented Feb 1, 2016

Fixed by latest PR.

@parente parente closed this as completed Feb 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants