-
Notifications
You must be signed in to change notification settings - Fork 48
Fix progress bar (and other styling) #10
Comments
Refs #10 (c) Copyright IBM Corp. 2016
Refs #10 🐷 (c) Copyright IBM Corp. 2016
All obvious styling differences seen with the simple dashboard have been fixed. As we add more widget support we will continue to fix styling discrepancies. |
Our fix for the output area didn't work correctly because of an issue in the |
@sccolbert @blink1073 Any idea when you might cut RC1 of phosphor-widget? |
@parente I can cut an |
That config does not affect Webpack. |
@dalogsdon As Steve said, that package setting only affects the browserify CSS transform. It has no bearing on webpack. Are you seeing something which doesn't work with the |
Ah, you're using Browserify, I was confused by the Webpack file. |
They're using a separate transform step in gulp, looks like the browserify config interferes with it. |
Ah. Yet another reason to not use browserify :) edit: some tools require that package setting, other tools break with that setting. |
The |
@blink1073 We are using both browserify and webpack at the moment, and yes it was interfering and causing an error which I don't have handy at the moment. @sccolbert Thanks for the |
Prevents slight shifting of content on initial load. Ref jupyter#10 (c) Copyright IBM Corp. 2016
Overlap in dashboard seems to be related to Ah. Known issue in Gridstack: gridstack/gridstack.js#307 |
Fixed by latest PR. |
Fix styling issues:
phosphor-widget
is updated to1.0.0-rc1
or later, re-commit 94d734d.localhost
).The text was updated successfully, but these errors were encountered: