Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd for wasm build #641

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

trungleduc
Copy link
Contributor

@trungleduc
Copy link
Contributor Author

@martinRenou @JohanMabille do you know if the failed tests are related to my changes?

@trungleduc trungleduc requested review from JohanMabille and DerThorsten and removed request for JohanMabille October 21, 2024 09:10
@anutosh491
Copy link
Contributor

It seems the error comes out of this test

TEST_CASE("external_next_continue")

If you need this to go in, maybe you could comment this and add a TODO ?

@anutosh491
Copy link
Contributor

It seems some specific operations might be going wrong (first external_next_continue fails and now next_continue)
We had all tests working as expected during the last release. Haven't looked into it but not sure why some tests fail now.

@trungleduc could you check and add todo's for the failing ones. I shall look into them once that is done !

@anutosh491
Copy link
Contributor

anutosh491 commented Oct 21, 2024

I guess we can do what you did but what I meant was to only comment out the tests that fail (I guess a couple would fail) and add todos for only what fails

Otherwise a better way to do this might be to comment this out and add a todo

- name: Test xeus-python C++
run: ./test_xeus_python
timeout-minutes: 4
working-directory: build/test

And these out

test_debugger.cpp
xeus_client.hpp
xeus_client.cpp

So that we don't end up with this and we know the tests need to be fixed.

Run ./test_xeus_python
[doctest] doctest version is "2.4.11"
[doctest] run with "--help" for options
===============================================================================
[doctest] test cases: 0 | 0 passed | 0 failed | 0 skipped
[doctest] assertions: 0 | 0 passed | 0 failed |
[doctest] Status: SUCCESS!

@trungleduc trungleduc force-pushed the add-zstd branch 3 times, most recently from ff8fca0 to 8b59978 Compare October 21, 2024 11:57
@trungleduc
Copy link
Contributor Author

@anutosh491 is it ok now?

Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures of the debugger tests are not related to your changes. I think we can merge this one and investigate the failing tests in a dedicated PR.

@JohanMabille JohanMabille merged commit 739c12e into jupyter-xeus:main Oct 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants