Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make wasm build more consistent #605

Merged
merged 3 commits into from
Dec 7, 2023
Merged

make wasm build more consistent #605

merged 3 commits into from
Dec 7, 2023

Conversation

DerThorsten
Copy link
Member

@DerThorsten DerThorsten commented Dec 7, 2023 •
edited
Loading

  • Using the same name for the binary in the wasm case allows us to keep the kernel.json as it used to be, ie no more wasm_file entry in the metadata. When we need to figure out where the wasm/js is, we can just take argv[0] from the kernel.json.
  • Install wasm binaries to $PREFIX/bin instead $PREFIX/share/jupyter/kernels/xpython
  • Remove superfluous patches
  • Remove not needed part of ci

martinRenou
martinRenou approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@martinRenou martinRenou merged commit c935c5f into jupyter-xeus:main Dec 7, 2023
13 checks passed
@DerThorsten DerThorsten deleted the classify branch December 7, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

@JohanMabille JohanMabille Awaiting requested review from JohanMabille

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerThorsten @martinRenou