Allow initial values for model attributes to be specified on creation of the models #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
force-pushed
the
no_first_state
branch
2 times, most recently
from
62a2576 to
99ccc93
Compare
SylvainCorlay
force-pushed
the
no_first_state
branch
from
99ccc93 to
10eb557
Compare
|
@jdfreder this seems to complete the blocking issue on persistence for widgets created from the front-end. |
SylvainCorlay
changed the title
|
I like the resulting centralization of deserialization here. 👍 |
|
Nice, this is great cleanup @SylvainCorlay ! |
jdfreder
added a commit
that referenced
this pull request
Feb 22, 2016
Allow initial values for model attributes to be specified on creation of the models
|
🎉 |
| @@ -194,7 +172,7 @@ var WidgetModel = Backbone.Model.extend({ | |||
| for (var i=0; i<buffer_keys.length; i++) { | |||
| state[buffer_keys[i]] = buffers[i]; | |||
| } | |||
| return that._deserialize_state(state); | |||
| return that.constructor._deserialize_state(state, that.manager); | |||
There was a problem hiding this comment.
Shouldn't this be that.widget_manager?
jdfreder
added a commit
to jdfreder/ipywidgets
that referenced
this pull request
Feb 22, 2016
introduced in jupyter-widgets#383
Merged
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attributesargument so that we can create widget models with initial values._deserialize_stateis now a class method. We need that so that we can deserialize state before instantiating the model, and pass the full deserialized state to the model constructors._deserialize_statecannot take the model instance as a second argument anymore. And therefore, the same is also true for the custom serializers. Custom deserializers were actually not using this second argument, except the model deserialization (IPY_MODEL_***to model instance) which in fact only needed a reference to the widget manager. Hence, the second argument passed to_deserialize_stateand the custom serializers is now the widget manager itself._first_stateattribute has been removed from the base model, simplifying our overload of backbone.Model.set.readyevent that was removed since it is not needed anymore. This should solve the last issues with Controller widget persistence.This is a negative contribution in the number of lines, so a good sign!