Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deepcopy with structuredClone over JSON.parse/stringify #3697

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: deepcopy with structuredClone over JSON.parse/stringify #3697

merged 1 commit into from
Feb 13, 2023

Conversation

maartenbreddels
Copy link
Member

Backport of #3689 from main/8.x to 7.x

cc @manzt

@bollwyvl
Copy link
Contributor

bollwyvl commented Feb 7, 2023

Nice. Looks fine on caniuse... safari in a worker doesn't seem like a blocker.

Of note, lumino also offers a deepCopy, which might be an intermediate fallback before the painful JSON roundtrip.

@jasongrout jasongrout merged commit 5f2e97a into jupyter-widgets:7.x Feb 13, 2023
@maartenbreddels
Copy link
Member Author

I think that would be better, and we should do it for 7.x and main/8.x

@jasongrout jasongrout mentioned this pull request Feb 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maartenbreddels @bollwyvl @jasongrout