Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 7.x] Use control comm target in LabManager #3337

Merged
merged 2 commits into from
Feb 11, 2022
Merged

[Backport 7.x] Use control comm target in LabManager #3337

merged 2 commits into from
Feb 11, 2022

Commits on Feb 9, 2022

  1. Backport PR jupyter-widgets#3335: Use control comm target in LabManager

    @martinRenou
    martinRenou committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    a8a9a35 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Refine loadFromKernel function to handle asynchronous issues 

    - We need the models registered synchronously before they are actually created,
  so I broke the comm/model instantiation into two steps to make sure that
  new_model is the first synchronous call in its function.
- renamed loadFromKernelSlow to loadFromKernelModels to be more descriptive
- clean up a few obsolete comments
- Make sure we are using the appropriate buffers for a given widget's state.
    @jasongrout
    jasongrout committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    0296e03 View commit details
    Browse the repository at this point in the history