Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Inspector example used a wrong callback argument signature #3302

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

NichtJens
Copy link

I ran into an issue described here ipython/ipython#12214 for the Variable Inspector example.

The inspector.close() line would crash with the slightly cryptic message:

ValueError: Function <bound method VariableInspectorWindow._fill of <__main__.VariableInspectorWindow object at 0x2b7148c38a58>> is not registered as a post_run_cell callback

... despite the callback clearly being registered.

The fix is to a accept a second argument in the callback.

@jasongrout
Copy link
Member

Closed/reopened to trigger another test run.

@jasongrout jasongrout changed the base branch from 7.x to master November 30, 2021 18:05
@jasongrout jasongrout changed the base branch from master to 7.x November 30, 2021 18:05
@jasongrout jasongrout merged commit a2a31ce into jupyter-widgets:7.x Dec 7, 2021
@jasongrout jasongrout added this to the 7.7 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants