-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgetsnbextension: throw error on failure to render #3280
Widgetsnbextension: throw error on failure to render #3280
Conversation
+1 on this. This will enable viewing alternative mime types when widgets cannot be rendered. It would be interesting to have a independent release of widgetsnbextension with that change. |
fdf1748
to
7306b8e
Compare
TODO
|
2d14e92
to
01c77f0
Compare
Now doing a Notebook version check to not change the behavior for Notebook 6.4.4 and before. |
01c77f0
to
8081afc
Compare
Discussed during the ipywidgets call. Merging as decided in the call. |
@meeseeksdev backport to 7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
…on_failure_to_render Widgetsnbextension: throw error on failure to render
Backport PR #3280 on branch 7.x (Widgetsnbextension: throw error on failure to render)
Backported to 7.x in #3290 |
This goes in pair with jupyter/notebook#6181