Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgetsnbextension: throw error on failure to render #3280

Conversation

martinRenou
Copy link
Member

This goes in pair with jupyter/notebook#6181

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch martinRenou/ipywidgets/throw_error_on_failure_to_render

@SylvainCorlay
Copy link
Member

+1 on this.

This will enable viewing alternative mime types when widgets cannot be rendered. It would be interesting to have a independent release of widgetsnbextension with that change.

@martinRenou martinRenou force-pushed the throw_error_on_failure_to_render branch 2 times, most recently from fdf1748 to 7306b8e Compare September 21, 2021 10:46
@martinRenou
Copy link
Member Author

TODO

  • What happens for current Notebook?
  • Should we do a Notebook version check?

@martinRenou martinRenou force-pushed the throw_error_on_failure_to_render branch 2 times, most recently from 2d14e92 to 01c77f0 Compare September 24, 2021 10:28
@martinRenou
Copy link
Member Author

Now doing a Notebook version check to not change the behavior for Notebook 6.4.4 and before.

@martinRenou martinRenou force-pushed the throw_error_on_failure_to_render branch from 01c77f0 to 8081afc Compare September 24, 2021 10:30
@SylvainCorlay SylvainCorlay merged commit 3558ce6 into jupyter-widgets:master Sep 28, 2021
@SylvainCorlay
Copy link
Member

Discussed during the ipywidgets call. Merging as decided in the call.

@SylvainCorlay
Copy link
Member

@meeseeksdev backport to 7.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 28, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 7.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 3558ce6a22b4a6b1badb69f0507a6ac5b245a17f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #3280: Widgetsnbextension: throw error on failure to render'
  1. Push to a named branch :
git push YOURFORK 7.x:auto-backport-of-pr-3280-on-7.x
  1. Create a PR against branch 7.x, I would have named this PR:

"Backport PR #3280 on branch 7.x (Widgetsnbextension: throw error on failure to render)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@martinRenou martinRenou deleted the throw_error_on_failure_to_render branch September 28, 2021 17:18
SylvainCorlay added a commit to SylvainCorlay/ipywidgets that referenced this pull request Sep 29, 2021
…on_failure_to_render

Widgetsnbextension: throw error on failure to render
SylvainCorlay added a commit that referenced this pull request Sep 30, 2021
Backport PR #3280 on branch 7.x (Widgetsnbextension: throw error on failure to render)
@jasongrout jasongrout added this to the 8.0 milestone Dec 9, 2021
@jasongrout
Copy link
Member

Backported to 7.x in #3290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants