Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nouislider #3216

Merged
merged 9 commits into from
Jun 29, 2021
Merged

Commits on Jun 22, 2021

  1. Update nouislider

    jasongrout committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    a2dcb1c View commit details
    Browse the repository at this point in the history
  2. Fix NoUISlider type issues

    Signed-off-by: Itay Dafna <[email protected]>
    ibdafna committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ebbd3c9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #5 from ibdafna/jason_noui

    Fix NoUISlider type issues
    jasongrout authored Jun 22, 2021
    Configuration menu
    Copy the full SHA
    015963e View commit details
    Browse the repository at this point in the history
  4. Update reference screenshot for ui test.

    It seems that the the FloatLogSlider was wrong in master. This PR fixes it so it is consistent with ipywidgets 7.0. For example, in master setting the value to 10 causes the widget .value to be 10**10, and setting the value to 9 causes the widget .value to be 10**-9.
    jasongrout committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c86b98f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Update to nouislider 15.2.0.

    We pin the version since we need to manually update css when we update the version.
    jasongrout committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    31364d9 View commit details
    Browse the repository at this point in the history
  2. Update yarn.lock

    jasongrout committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7f3efb6 View commit details
    Browse the repository at this point in the history
  3. Update nouislider CSS to 15.2.0, and move our custom css to another f…

    …ile to make updating easier.
    jasongrout committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b0251d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Store the values that have been synced to the kernel, but are still l…

    …isted as changed, so they do not get buffered again to be synced to the kernel.
    
    This fixes a problem that comes up when we have a recursive call to .set (for example, when a top-level .set call triggers an event which leads to another .set call), and the state is synced while in this recursive call. In short, the end of every .set call involves copying over the changed attributes to _buffered_state_diff. However, if we’ve already sent the state to the kernel during this recursive .set call (which clears _buffered_state_diff), before this PR we still copied over the state change values another time into _buffered_state_diff.
    
    This PR instead keeps track of the last values we have sent to the kernel during a recursive .set call, so that we don’t redundantly copy these values into the buffer again.
    
    See jupyter-widgets#3216 (comment) and the following comments for more notes on this issue.
    jasongrout committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6127306 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a975b57 View commit details
    Browse the repository at this point in the history