-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nouislider #3216
Merged
ibdafna
merged 9 commits into
jupyter-widgets:master
from
jasongrout:upgrade-nouislider
Jun 29, 2021
Merged
Upgrade nouislider #3216
ibdafna
merged 9 commits into
jupyter-widgets:master
from
jasongrout:upgrade-nouislider
Jun 29, 2021
Commits on Jun 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a2dcb1c - Browse repository at this point
Copy the full SHA a2dcb1cView commit details -
Signed-off-by: Itay Dafna <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ebbd3c9 - Browse repository at this point
Copy the full SHA ebbd3c9View commit details -
Merge pull request #5 from ibdafna/jason_noui
Fix NoUISlider type issues
Configuration menu - View commit details
-
Copy full SHA for 015963e - Browse repository at this point
Copy the full SHA 015963eView commit details -
Update reference screenshot for ui test.
It seems that the the FloatLogSlider was wrong in master. This PR fixes it so it is consistent with ipywidgets 7.0. For example, in master setting the value to 10 causes the widget .value to be 10**10, and setting the value to 9 causes the widget .value to be 10**-9.
Configuration menu - View commit details
-
Copy full SHA for c86b98f - Browse repository at this point
Copy the full SHA c86b98fView commit details
Commits on Jun 25, 2021
-
We pin the version since we need to manually update css when we update the version.
Configuration menu - View commit details
-
Copy full SHA for 31364d9 - Browse repository at this point
Copy the full SHA 31364d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f3efb6 - Browse repository at this point
Copy the full SHA 7f3efb6View commit details -
Update nouislider CSS to 15.2.0, and move our custom css to another f…
…ile to make updating easier.
Configuration menu - View commit details
-
Copy full SHA for b0251d2 - Browse repository at this point
Copy the full SHA b0251d2View commit details
Commits on Jun 28, 2021
-
Store the values that have been synced to the kernel, but are still l…
…isted as changed, so they do not get buffered again to be synced to the kernel. This fixes a problem that comes up when we have a recursive call to .set (for example, when a top-level .set call triggers an event which leads to another .set call), and the state is synced while in this recursive call. In short, the end of every .set call involves copying over the changed attributes to _buffered_state_diff. However, if we’ve already sent the state to the kernel during this recursive .set call (which clears _buffered_state_diff), before this PR we still copied over the state change values another time into _buffered_state_diff. This PR instead keeps track of the last values we have sent to the kernel during a recursive .set call, so that we don’t redundantly copy these values into the buffer again. See jupyter-widgets#3216 (comment) and the following comments for more notes on this issue.
Configuration menu - View commit details
-
Copy full SHA for 6127306 - Browse repository at this point
Copy the full SHA 6127306View commit details -
Configuration menu - View commit details
-
Copy full SHA for a975b57 - Browse repository at this point
Copy the full SHA a975b57View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.