Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packages using --minimal #3215

Merged
merged 8 commits into from
Jun 15, 2021

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Jun 11, 2021

This includes #3211, so that should be merged first.

This upgrades packages using:

yarn run update-dependency --regex '^(?!@jupyter-widgets).*' latest --minimal

I reset nouislider, @types/nouislider, and @types/backbone back to their existing versions in 3ebf031 since the upgrades introduced some errors in the build. We can take a look at those upgrades in a different PR, to let the majority of the upgrades here proceed.

Note: I had to manually patch the update script with the changes at jupyterlab/jupyterlab#10393 for the update script to work.

@jasongrout jasongrout marked this pull request as ready for review June 11, 2021 20:58
@jasongrout jasongrout added this to the 8.0 milestone Jun 11, 2021
This was referenced Jun 11, 2021
This is from running:

    yarn run update-dependency --regex '^(?!@jupyter-widgets).*' latest --minimal
The upgrades were causing compilation errors, so I reverted them to be looked at later.
I did this by deleting the yarn.lock and then doing a fresh yarn install.
I’m saving fixing a lot of the lint warnings for a different PR.
@jtpio
Copy link
Member

jtpio commented Jun 15, 2021

Thanks!

Just rebase now that #3211 has been merged.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit db12823 into jupyter-widgets:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants