Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to ipykernel<6 for the docs #3155

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 10, 2021

Fixes #3154

@jtpio jtpio marked this pull request as draft March 10, 2021 09:12
@jtpio jtpio added the docs label Mar 10, 2021
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jtpio/ipywidgets/docs-build

@jtpio
Copy link
Member Author

jtpio commented Mar 10, 2021

Looking at the RTD logs, it looks like it was pulling ipykernel==6.0.0a0:

image

https://readthedocs.org/api/v2/build/13206952.txt

@jtpio jtpio marked this pull request as ready for review March 10, 2021 09:15
@jtpio jtpio changed the title Pin to ipykernel<6 Pin to ipykernel<6 for the docs Mar 10, 2021
@jtpio
Copy link
Member Author

jtpio commented Mar 10, 2021

cc @ianhi I think we could keep this pin until ipykernel stabilizes.

@ianhi
Copy link
Contributor

ianhi commented Mar 10, 2021

Using ipywidgets fails for me with ipykernel 6a. So maybe this isn't the correct fix?

@ianhi
Copy link
Contributor

ianhi commented Mar 10, 2021

See #3157

Should we merge this anyway in order to have the docs work on any new PRs?

@jtpio
Copy link
Member Author

jtpio commented Mar 11, 2021

Using ipywidgets fails for me with ipykernel 6a. So maybe this isn't the correct fix?

Isn't it the same issue? Since RTD was pulling ipykernel==6.0.0a0 (probably because of a --pre somewhere)

Should we merge this anyway in order to have the docs work on any new PRs?

It should be ready to go yes, and we can continue tracking this in #3157.

@ianhi
Copy link
Contributor

ianhi commented Mar 11, 2021

Isn't it the same issue? Since RTD was pulling ipykernel==6.0.0a0 (probably because of a --pre somewhere)

Yeah the same issue, but my thought was just that this was more so fixing a symptom rather than the root cause.

Should we merge this anyway in order to have the docs work on any new PRs?

It should be ready to go yes, and we can continue tracking this in #3157.

right on. thanks!

@ianhi ianhi merged commit 042a7ae into jupyter-widgets:master Mar 11, 2021
@jtpio
Copy link
Member Author

jtpio commented Mar 11, 2021

Yeah the same issue, but my thought was just that this was more so fixing a symptom rather than the root cause.

Sure. I think the root cause is being investigated in ipython/ipykernel#602

@jtpio jtpio deleted the docs-build branch March 11, 2021 15:07
@jtpio jtpio added this to the 8.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc build Failing
2 participants