Add handle_color style key to SelectionSlider #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks good to me. To make the tests pass, you need to update the latest model spec for the selection slider in https://github.com/jupyter-widgets/ipywidgets/blob/master/packages/schema. |
|
(could you also fix the JSON schema file?) |
|
Seems like it worked. Hooray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SelectionSlider widget has a very similar interface to the FloatSlider and IntSlider, but is missing the handle_color style. This adds it. Seems to work for me, but I'm not super familiar with UI coding and don't know how to write tests for this. I don't see tests for this feature implemented similarly on the FloatSlider. If this needs a test, please point me to a test for something similar and I can probably figure it out. Thanks!