Traitlets 4 vs 5 changes defaults in message spec #3110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get these by these commands from the release docs: python ./packages/schema/generate-spec.py -f json-pretty > packages/schema/jupyterwidgetmodels.latest.json python ./packages/schema/generate-spec.py -f markdown > packages/schema/jupyterwidgetmodels.latest.md
|
It looks like these differences are caused by traitlets 4 vs traitlets 5. That is something we need to look into, but not a blocker for an alpha release, I think. |
|
Converting to draft since this needs more discussion before merging (or closing) |
jasongrout
changed the title
|
Traitlets 4: Traitlets 5: |
|
Note that: >>> traitlets.__version__
'5.0.5'
>>> Tuple().make_dynamic_default()
()
>>> Tuple(traitlets.Unicode()).make_dynamic_default()
<blank = None> |
|
I added a fix for this to #3174 (since it is painful to work with specs on Windows without it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get these by these commands from the release docs:
I noticed that these gave updates that were not already in the files. It seems that our updated packages now give updated formatting to the json, so it's probably more instructive to look at the two small changes in the .md file.