Adapt the milestone_check script from JupyterLab for ipywidgets. #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script compares the commits in a repo associated with a certain milestone to the pull requests for the milestone. It verifies: * Every PR on the milestone has at least one commit in the associated commit range in git * Every commit in the commit range in git is in a PR associated with the milestone * Any merge commit from a PR in the milestone commit range where the PR is not in the milestone. This makes it easier to clean up PR milestones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script compares the commits in a repo associated with a certain milestone to the pull requests for the milestone. It verifies:
This makes it easier to clean up PR milestones.
For example, running the script for the 8.0 milestone right now flags about 43 PRs that may need to be assigned to the 8.0 milestone, based on where their commits fall in the tree (i.e., on master, but not as an ancestor of the 7.x branch).