-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make INotebookTracker optional in the manager plugin #3033
Conversation
Just curious, how are you registering the widget manager in the case where you do not have a tracker? |
@jtpio The change in itself is ok, but as Jason points out, there probably needs to be additional changes to allow for providing the context. To make it more reusable for other things, it would probably also make sense to make changes to the manager to separate:
|
For now the main motivation is when the
Yes absolutely. It sounds like it would also make it easier to provide widget support for code consoles: #3004 |
Merging since this doesn't hurt anything, and helps slightly in the classic case (or other cases where there is not a notebook tracker). |
I'll note that master (8.0) does not have this issue, I think courtesy of #2528 |
Also note that I had completely forgotten that the work to split the kernel manager to not need document context was already done (by me, even!) in master: ipywidgets/jupyterlab_widgets/src/manager.ts Line 416 in 3108308
|
Ah nice! We probably didn't realize since this PR was against the 7.x branch. |
This should help make the plugin more flexible.
For example when it is loaded as a federated extension on a page that doesn't provide the
@jupyterlab/notebook-extension:tracker
.