Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate FileUpload value by using a single top-level dict #2724

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 11, 2020

Fixes part of #2721.
Continuation of #2666.

The FileUpload value now follows this structure:

uploader.value
#=> [
#=>   {
#=>     'name': 'example.txt',
#=>     'type': 'text/plain',
#=>     'size': 36,
#=>     'lastModified': 1578647380733, 
#=>     'content': <memory at 0x10c1b37c8>
#=>   }
#=> ]

@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit 0cdae8f into jupyter-widgets:master Jan 11, 2020
@jtpio jtpio deleted the file-upload-content branch January 11, 2020 16:04
@pbugnion
Copy link
Member

Nice!

@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@jasongrout jasongrout added this to the 8.0 milestone Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants