-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements.txt and postBuild for Binder #2701
Conversation
Probably because |
Does that mean that a dev install of |
Yes, since a few days ago.
No, it requires installing a JupyterLab 2 beta. See the developer documentation for instance. |
7f0051a
to
a28bf55
Compare
Clarification, since you asked two questions: ipywidgets master requires the jlab 2.0.0 beta 2, not a dev install of JuptyerLab. In other words, the documentation @pbugnion should work. |
Thanks a lot, now it works! Here's the JupyterLab link: https://mybinder.org/v2/gh/mgeier/ipywidgets/binder-requirements?urlpath=lab/tree/docs/source/examples An the Classic Notebook link: https://mybinder.org/v2/gh/mgeier/ipywidgets/binder-requirements?filepath=docs/source/examples |
@mgeier Thanks for pushing this through. I think we should still clarify whether we really want a dev-install, as started in #2659. I think this depends on what we think the point of the binder link is. Is it:
If it's (1), then I think a dev-install is detrimental, and we should always install the built, stable version. The problem with a dev-install is that it takes 10 minutes to start if the layer containing the node_modules isn't cached. It's also much more likely to break than pulling in pre-built JS dependencies. I think we very much want to target (1) in the link in the README. One possibility could be to
This would cater to both use cases. @mgeier I'd be keen to hear your thoughts as well as @jtpio and other maintainers. |
How often would that happen?
Do you mean that it could break between two different commits or between to builds of the same commit? |
@pbugnion Do you have answers to my questions? I think it would be ideal if both use cases you mentioned could be covered by the same setup. If there are issues with that, it would be great if we could solve them. If that turns out to be impossible (or at least no feasible), we should consider implementing the two use cases separately. |
@mgeier thanks for bringing up this issue. I'm trying to understand which solution worked for you. Did you end up using jlab 2.0.0 beta 2, not a dev install of JuptyerLab? Plotly is new to me, and I brought up the same issue to the Plotly Community: https://community.plotly.com/t/getting-started-with-plotly-widgets-and-jupyterlabs-conflicting-dependencies/36974 |
The answer to your question at https://community.plotly.com/t/getting-started-with-plotly-widgets-and-jupyterlabs-conflicting-dependencies/36974 is to just install the extension with:
It will figure out the right version to get and install. You saw a problem since you said specifically to install version 1.1 (that's the |
@jasongrout thanks for the quick reply! I realized the mistake after reading your response and reading the README https://github.com/jupyter-widgets/ipywidgets/tree/master/packages/jupyterlab-manager I tried to reinstall using:
This worked all the way up until the jupyter lab build call
I also tried your recommendation
Thanks! |
The current version of this PR (a28bf55) works on binder (at least it worked at that time), see the links in #2701 (comment).
Yes, exactly. |
Likely you can use the actual jlab 2.0 final release at this point. |
@jasongrout and @mgeier, thanks for the responses. If either are curious, installing manager@2 |
a28bf55
to
6468188
Compare
I've re-based this PR and I've changed the JupyterLab dependency to It still works: https://mybinder.org/v2/gh/mgeier/ipywidgets/binder-requirements?urlpath=lab/tree/docs/source/examples |
6468188
to
74f2135
Compare
Just rebased onto the latest |
Now that we have a dev Binder bot to easily test new PRs (#3148), it looks like it would make sense to setup Binder to install from source with the For example to test this branch: Based on the discussion above, it sounds like it would still make sense to also provide a "stable" Binder that would install cc @ianhi |
So as a conclusion I would be in favor or merging this PR as is, at least as a first step. This would make it very convenient to try out changes for new PRs without having to manually check out the code locally. And fix #3152 |
Makes sense to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an alternative to #2659 which also tries to fix #2301.
Closes #2659
Using
jupyterlab==1
inrequirements.txt
I can avoid the error from #2659 and the Binder image finally finishes building and is actually launched.The problem, however, is that it still doesn't work. The widgets are not displayed in JupyterLab (but they work fine in the Classic Notebook).
Here's the Binder link: https://mybinder.org/v2/gh/mgeier/ipywidgets/binder-requirements?urlpath=lab/tree/docs/source/examples