Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package license files #2048

Closed
wants to merge 3 commits into from
Closed

Package license files #2048

wants to merge 3 commits into from

Conversation

jakirkham
Copy link

Make sure the license files get included in the various sdists.

jakirkham and others added 3 commits April 15, 2018 20:12
@jakirkham
Package COPYING.md and LICENSE
404bcfd 
Make sure `COPYING.md` and `LICENSE` are in the `sdist`.
@jakirkham
Package LICENSE
9672a57 
Make sure the `LICENSE` is included in `sdist`s.
@jakirkham
Copy license files into widgetsnbextension
6b83bfd 
Appears that referencing the higher level directory does not work with
`MANIFEST.in`.

ref: https://stackoverflow.com/a/27651742
@jasongrout
Copy link
Member

Thanks!

@jakirkham
Copy link
Author

Anything else?

@jasongrout
Copy link
Member

Sorry, I've been busy with JupyterLab lately. Looking at this more closely, perhaps we should solve #1701 first to clear up the confusion rather than propagating it into the packages. Let me look at that first (e.g., #1706)

@jasongrout jasongrout added this to the 7.3 milestone Jul 6, 2018
jasongrout added a commit to jasongrout/ipywidgets that referenced this pull request Jul 16, 2018
@jasongrout
Clarify license files.
5f1c665 
Based on discussion at jupyter/governance#37 and discussion from the links on that issue, I made the following changes:

1. Delete the COPYING.md, as it was redundant
2. Changed the LICENSE copyright dates to just have the starting year

I also added LICENSE to the widgetsnbextension package (thanks to @jakirkham for noticing this in jupyter-widgets#2048).

This supersedes jupyter-widgets#1706, which was reverted in master while the discussion was still happening.
@jasongrout jasongrout mentioned this pull request Jul 16, 2018
Merged
@jasongrout
Copy link
Member

Thanks! Fixed by #2133.

@jasongrout jasongrout closed this Jul 17, 2018
@jasongrout jasongrout mentioned this pull request Jul 17, 2018
Closed
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @jasongrout