Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve instead of return Promise #1633

Merged
merged 2 commits into from
Aug 15, 2017

Conversation

maartenbreddels
Copy link
Member

followup of #1630

var p = new Promise((resolve, reject) => {
    return Promise.resolve(1) // this does not resolve
}).then((value) => {
    console.log('got value', value)
})

var p = new Promise((resolve, reject) => {
    resolve(Promise.resolve(1)) // should be this or maybe .then(resolve, reject) ?
}).then((value) => {
    console.log('got value', value)
})

Is this pattern maybe present in more places?

@jasongrout
Copy link
Member

Great catch!

@jasongrout jasongrout merged commit f9088b5 into jupyter-widgets:master Aug 15, 2017
@jasongrout jasongrout added this to the 7.0 milestone Aug 15, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants