Allow selected_index=none in selection container widgets
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pbugnion
force-pushed
the
selection-container-allow-none
branch
from
f3806bc
to
b6ec556
Compare
pbugnion
changed the title
selected_index=none in selection container widgetsselected_index=none in selection container widgets
pbugnion
force-pushed
the
selection-container-allow-none
branch
from
7494306
to
88ba725
Compare
jasongrout
reviewed
Jul 14, 2017
| @@ -130,7 +130,7 @@ class TabPanel extends Widget { | |||
| * Set the index of the currently selected tab. | |||
| * | |||
| * #### Notes | |||
| * If the index is out of range, it will be set to `-1`. | |||
| * If the index is out of range, it will be set to `null`. | |||
There was a problem hiding this comment.
It looks like the logic here is still missing for out of range values.
There was a problem hiding this comment.
Actually, you don't need to do anything here - the tab bar handles the logic to set its current index to -1 if out of range. We'll just handle the translation to null up where we retrieve the index.
jasongrout
reviewed
Jul 14, 2017
| @@ -120,7 +120,7 @@ class TabPanel extends Widget { | |||
| * Get the index of the currently selected tab. | |||
| * | |||
| * #### Notes | |||
| * This will be `-1` if no tab is selected. | |||
| * This will be `null` if no tab is selected. | |||
| */ | |||
| get currentIndex(): number { | |||
| return this.tabBar.currentIndex; | |||
There was a problem hiding this comment.
Logic needs to be added here to return null if the tab bar index is -1.
|
Thanks! |
This was referenced Jul 15, 2017
Closed
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the way to unset the selection for a tab or accordion widget was to set
selected_index = -1. Having to set it toNonewould be better (see issue #1493 ).This PR allows setting the index to None. The bulk of the changes are in the
Selectionclass, which now allows setting the index to null.This is what's left to do:This is now ready for review.