Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make widgets render using output areas in classic notebook. #1274

Merged
merged 20 commits into from
Apr 18, 2017
Merged

Make widgets render using output areas in classic notebook. #1274

merged 20 commits into from
Apr 18, 2017

Commits on Apr 13, 2017

  1. WIP make widgets render using output areas in classic notebook.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    000609b View commit details
    Browse the repository at this point in the history

  2. Delete even more unnecessary code

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    23ed670 View commit details
    Browse the repository at this point in the history

  3. Initialize the output config correctly.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    4653b0f View commit details
    Browse the repository at this point in the history

  4. Rerender cells after the widget manager has the widget model info.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    dfeaa1f View commit details
    Browse the repository at this point in the history

  5. Clean up comments

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    384c838 View commit details
    Browse the repository at this point in the history

  6. Don’t send comm message to display widgets anymore.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    3e77d13 View commit details
    Browse the repository at this point in the history

  7. Clean up unused function.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    1f3e21d View commit details
    Browse the repository at this point in the history

  8. Clean up widget manager display_model typescript.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    2488cc6 View commit details
    Browse the repository at this point in the history

  9. We won’t support a cell resize event anymore, since we may have multi… 

    …ple widgets in a cell.
    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    c5f125e View commit details
    Browse the repository at this point in the history

  10. Delete the disconnected indication. 

    See jupyter-widgets#1275 for bringing this back in a more general way.
    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    4946ff2 View commit details
    Browse the repository at this point in the history

  11. Get the Embed Widgets command working again.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    066b136 View commit details
    Browse the repository at this point in the history

  12. Delete widgetarea javascript

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    0094b78 View commit details
    Browse the repository at this point in the history

  13. Label widget views as unsafe.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    e14355d View commit details
    Browse the repository at this point in the history

  14. Delete unnecessary css.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d9807f0 View commit details
    Browse the repository at this point in the history

  15. Attempt to support calling .remove() when appropriate.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    609c804 View commit details
    Browse the repository at this point in the history

  16. Fix undefined bug.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    117a155 View commit details
    Browse the repository at this point in the history

  17. Fix calling .remove() when in an output widget.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    00b16dc View commit details
    Browse the repository at this point in the history

  18. Use the view.cid unique id as an identifying id.

    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    17b7ae7 View commit details
    Browse the repository at this point in the history

  19. Fix sync messages for the output widget. 

    The sync messages weren’t getting sent because the status handler was never getting called, which mean that once one message was sent and declared pending, we never realized when that message had been processed.
    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    340a0f1 View commit details
    Browse the repository at this point in the history

  20. Fix calling .remove() on views. 

    This depends on jupyter/notebook#2411 to get all the corner cases. We left in various other event triggers to cover most cases even without that PR.
    @jasongrout
    jasongrout committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    cd8c6e8 View commit details
    Browse the repository at this point in the history