Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate interact annotation syntax #1264

Closed
jasongrout opened this issue Apr 7, 2017 · 2 comments · Fixed by #1292
Closed

Deprecate interact annotation syntax #1264

jasongrout opened this issue Apr 7, 2017 · 2 comments · Fixed by #1292
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

jasongrout commented Apr 7, 2017

Annotations now have a somewhat "official" syntax in python, courtesy of https://www.python.org/dev/peps/pep-0484/. I propose we deprecate the annotation syntax for interacts.

The PEP does say:

Note that this PEP still explicitly does NOT prevent other uses of annotations, nor does it require (or forbid) any particular processing of annotations, even when they conform to this specification. It simply enables better coordination, as PEP 333 did for web frameworks.

However, I think the annotation syntax doesn't add enough value and our decorator-based syntax is not widespread enough to maintain it.

@SylvainCorlay, @ellisonbg, and others: thoughts?

@jasongrout jasongrout added this to the 7.0 milestone Apr 7, 2017
@ellisonbg
Copy link
Member

ellisonbg commented Apr 7, 2017 via email

@jasongrout
Copy link
Member Author

Okay, plan is to deprecate it in 7.0, remove it after some time has passed (a year?)

jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Apr 17, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants