Restore the ability to override a serverapp's HTTP port #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p listens on When invoking the `jp_configurable_serverapp` fixture, there are multiple keyword arguments supported for overriding the values specified by other fixtures. One of those keyword arguments, `http_port`, is never used. I believe this was accidentally broken by jupyter-server#33 where multiple variables named `http_port` referencing a provided fixture were renamed to `jp_http_port`. However, that change also modified one instance of `http_port` that was not a reference to the fixture, but rather a reference to the keyword argument with that same name. This change fixes that by undoing that one line of the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking the
jp_configurable_serverappfixture, there are multiple keyword arguments supported for overriding the values specified by other fixtures.One of those keyword arguments,
http_port, is never used. I believe this was accidentally broken by #33 where multiple variables namedhttp_portreferencing a provided fixture were renamed tojp_http_port.However, that change also modified one instance of
http_portthat was not a reference to the fixture, but rather a reference to the keyword argument with that same name.This change fixes that by undoing that one line of the change.