Enable header overrides in jp_ws_fetch fixture #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 94.34% 94.35% +0.01%
==========================================
Files 12 12
Lines 513 514 +1
==========================================
+ Hits 484 485 +1
Misses 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Zsailer
approved these changes
Mar 29, 2023
|
Thanks, @kevin-bates! LGTM! |
|
@Zsailer or @blink1073 - would it be possible to build a release to grab this update? I can follow the instructions on RELEASE.md if they're current and do the release if that helps. |
|
Go for it! The instructions look to be up to date. |
krassowski
added a commit
to krassowski/jupyter_server
that referenced
this pull request
Feb 20, 2024
enabled `jp_ws_fetch` header override in: gttps://github.com/jupyter-server/pytest-jupyter/pull/51
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the
jp_fetchfixture, there was no way to override the addition of theAuthorizationheader in thejp_ws_fetchfixture. This pull request bringsjp_ws_fetch's "header functionality" in line withjp_fetch's so that tests can set a differentAuthorizationheader over what is provided by thejp_auth_headerfixture.