Add appendStreamOutput and removeStreamOutput methods #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
stream-output
branch
from
ef3ba49
to
76e4073
Compare
davidbrochart
changed the title
|
I would like to merge this PR and make a release, so that jupyterlab/jupyterlab#16498 can be merged. |
Zsailer
approved these changes
Jun 24, 2024
|
LGTM! Thanks, @davidbrochart |
krassowski
reviewed
Sep 9, 2024
| @@ -737,7 +738,7 @@ export type CellChange = SourceChange & { | |||
| /** | |||
| * Cell output changes | |||
| */ | |||
| outputsChange?: Delta<nbformat.IOutput[]>; | |||
| outputsChange?: Delta<Y.Map<any>>; | |||
There was a problem hiding this comment.
We should improve typing here, any is not a great public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.