Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds id to cells #13

Merged
merged 1 commit into from
May 10, 2022
Merged

Adds id to cells #13

merged 1 commit into from
May 10, 2022

Conversation

hbcarlos
Copy link
Contributor

The shared models need the cell id to properly work. When opening a notebook with nbformat minor than 4.5 the cells don't contain id and we need to generate it.

@welcome
Copy link

welcome bot commented May 10, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

jupyter_ydoc/ydoc.py Outdated Show resolved Hide resolved
@davidbrochart davidbrochart merged commit 5b36f6b into jupyter-server:main May 10, 2022
@welcome
Copy link

welcome bot commented May 10, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@davidbrochart
Copy link
Collaborator

Thanks!

@hbcarlos hbcarlos deleted the cell_id branch May 10, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants