Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook metadata #115

Merged
merged 12 commits into from
Jan 3, 2023
Merged

Notebook metadata #115

merged 12 commits into from
Jan 3, 2023

Conversation

hbcarlos
Copy link
Contributor

Splits the ymodel.ts file into multiple files and changes the notebook's metadata to a YMap to use the same type as the cell's metadata.

@hbcarlos hbcarlos marked this pull request as draft December 22, 2022 17:31
@hbcarlos hbcarlos marked this pull request as ready for review December 23, 2022 10:32
@fcollonval fcollonval added the enhancement New feature or request label Jan 3, 2023
fcollonval
fcollonval requested changes Jan 3, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

tests/yarn.lock Outdated Show resolved Hide resolved
javascript/src/ynotebook.ts Outdated Show resolved Hide resolved
fcollonval
fcollonval reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of renaming Y...Cell.createStandalone to Y...Cell.create to align the API?

fcollonval
fcollonval approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

davidbrochart
davidbrochart approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Any idea about this failing test?

@fcollonval
Copy link
Member

I updated the job for fixing the license header. But it will work only once this is merged as you cannot push from a job that is running on a pull request branch; only in the targeted branch.

@fcollonval fcollonval merged commit 145f811 into jupyter-server:main Jan 3, 2023
@hbcarlos hbcarlos deleted the notebook_metadata branch January 4, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees

@hbcarlos hbcarlos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbcarlos @fcollonval @davidbrochart