Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore preference for SelectorEventLoop on Windows #513

Merged
merged 2 commits into from
May 13, 2021

Conversation

minrk
Copy link
Contributor

@minrk minrk commented May 9, 2021

tornado should still work better with Selector, even though 6.1 isn't broken with proactor. Picking Selector avoids the extra thread, which runs a Selector anyway.

So the choice is really between:

  • Proactor in main thread for coroutines, but ~all IO in a Selector in another thread
  • one Selector loop for everything

cf jupyter/notebook#6052

tornado should work better with Selector, even though 6.1 isn't *broken* with proactor.
Selector avoids the extra thread, which runs a Selector anyway.
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #513 (928f9dd) into master (627898f) will decrease coverage by 0.04%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
- Coverage   77.06%   77.01%   -0.05%     
==========================================
  Files         107      107              
  Lines        9495     9511      +16     
  Branches     1027     1032       +5     
==========================================
+ Hits         7317     7325       +8     
- Misses       1808     1814       +6     
- Partials      370      372       +2     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 66.77% <11.11%> (-0.47%) ⬇️
jupyter_server/pytest_plugin.py 90.76% <33.33%> (-0.96%) ⬇️
jupyter_server/_version.py 87.50% <0.00%> (-12.50%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 80.79% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 627898f...928f9dd. Read the comment docs.

@blink1073 blink1073 added this to the 1.7 milestone May 10, 2021
@blink1073 blink1073 modified the milestones: 1.7, 1.8 May 10, 2021
@vidartf
Copy link
Member

vidartf commented May 13, 2021

I think the test failures here are significant, especially since I would consider them unexpected.

@vidartf
Copy link
Member

vidartf commented May 13, 2021

From running locally: The test that will fail is always the first test to run the using the clever fixtures.

@vidartf
Copy link
Member

vidartf commented May 13, 2021

I added a commit that fixes the tests, but I'm not a 100% on why it fixes it (I have some vague hand-wavy idea, but not a solid understanding).

@blink1073 blink1073 modified the milestones: 1.8, 1.7 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants