-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some of ipython_genutils no-op. #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Carreau - this looks good. I just had the one comment regarding the "duplicated" import.
ipython_genutils is complicated to package on some linux distro because of nose, and in general not useful as it mostly offered python 2/3 compat layer. Goal always has been to remove any usage of ipython_genutils
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 77.75% 78.21% +0.46%
==========================================
Files 106 106
Lines 9269 9622 +353
Branches 997 1100 +103
==========================================
+ Hits 7207 7526 +319
- Misses 1706 1717 +11
- Partials 356 379 +23
Continue to review full report at Codecov.
|
rebased updated an pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Remove some of ipython_genutils no-op.
ipython_genutils is complicated to package on some linux distro because
of nose, and in general not useful as it mostly offered python 2/3
compat layer.
Goal always has been to remove any usage of ipython_genutils