Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kernel env to reflect changes in session #1354

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Update kernel env to reflect changes in session #1354

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b9b411
Revert "Revert "Update kernel env to reflect changes in session." (#1…
blink1073 Oct 25, 2023
9aacc95
Merge branch 'main' into revert-1346-revert-1341-forward-rename
blink1073 Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jupyter_server/services/sessions/sessionmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,13 @@ async def update_session(self, session_id, **kwargs):
query = "UPDATE session SET %s WHERE session_id=?" % (", ".join(sets)) # noqa
self.cursor.execute(query, [*list(kwargs.values()), session_id])

if hasattr(self.kernel_manager, "update_env"):
self.cursor.execute(
"SELECT path, name, kernel_id FROM session WHERE session_id=?", [session_id]
)
path, name, kernel_id = self.cursor.fetchone()
self.kernel_manager.update_env(kernel_id=kernel_id, env=self.get_kernel_env(path, name))

async def kernel_culled(self, kernel_id: str) -> bool:
"""Checks if the kernel is still considered alive and returns true if its not found."""
return kernel_id not in self.kernel_manager
Expand Down
Loading