-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more coverage #1069
Add more coverage #1069
Conversation
blink1073
commented
Nov 12, 2022
•
edited
Loading
edited
- Add more coverage for extension app and files handler (which was actually broken).
- Get windows-specific coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
+ Coverage 75.14% 75.63% +0.48%
==========================================
Files 63 63
Lines 8225 8222 -3
Branches 1635 1634 -1
==========================================
+ Hits 6181 6219 +38
+ Misses 1624 1576 -48
- Partials 420 427 +7 ☔ View full report in Codecov by Sentry. |
Question: should we deprecate the previously broken |
95b642a
to
2cd1696
Compare
We're going to keep the |