Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more coverage #1069

Merged
merged 15 commits into from
Nov 17, 2022
Merged

Add more coverage #1069

merged 15 commits into from
Nov 17, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 12, 2022

  • Add more coverage for extension app and files handler (which was actually broken).
  • Get windows-specific coverage

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.63%. Comparing base (830c87f) to head (ad66cb9).
Report is 296 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
+ Coverage   75.14%   75.63%   +0.48%     
==========================================
  Files          63       63              
  Lines        8225     8222       -3     
  Branches     1635     1634       -1     
==========================================
+ Hits         6181     6219      +38     
+ Misses       1624     1576      -48     
- Partials      420      427       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073
Copy link
Contributor Author

Question: should we deprecate the previously broken FilesHandler class?

@blink1073
Copy link
Contributor Author

We're going to keep the FileHandler class, since it is used by default for ContentsManager, while FileContentsManager uses the AuthenticatedFileHandler class. Both are actually authenticated, which is an unfortunate naming.

@blink1073 blink1073 merged commit 28577cf into jupyter-server:main Nov 17, 2022
@blink1073 blink1073 deleted the moar-coverage branch November 17, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant