Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminals excluded from activity monitoring #432

Closed
minrk opened this issue Mar 1, 2021 · 3 comments · Fixed by #438
Closed

terminals excluded from activity monitoring #432

minrk opened this issue Mar 1, 2021 · 3 comments · Fixed by #438

Comments

@minrk
Copy link
Contributor

minrk commented Mar 1, 2021

Kernels are monitored for activity and can be shutdown when they have been idle for some period of time. Terminals, on the other hand, are not observed for activity and therefore never treated as idle. This has two consequences:

  1. terminals cannot be shutdown by some idle timeout
  2. if any terminal is started and not terminated, shutdown_no_activity will never teardown the server itself.

This would help e.g. jupyterhub deployments that want to shutdown after some idle time.

@kevin-bates
Copy link
Member

I think we need to port jupyter/notebook#5372 to server (and make jupyter/notebook#5465 is there as well).

@minrk
Copy link
Contributor Author

minrk commented Mar 2, 2021

Awesome! I didn't notice this had landed in the classic server already.

@kevin-bates
Copy link
Member

We also need to bring jupyter/notebook#5462 to the party as well.

Zsailer added a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants