Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of error output #79

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Fix handling of error output #79

merged 1 commit into from
Jul 19, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jul 19, 2021

Follow up to #77, addresses error seen in publish workflow

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #79 (4aff85d) into master (5b17742) will decrease coverage by 3.84%.
The diff coverage is 69.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   89.03%   85.19%   -3.85%     
==========================================
  Files          15       16       +1     
  Lines        1697     1898     +201     
  Branches      198      239      +41     
==========================================
+ Hits         1511     1617     +106     
- Misses        118      190      +72     
- Partials       68       91      +23     
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/util.py 69.87% <46.87%> (-15.02%) ⬇️
jupyter_releaser/changelog.py 88.18% <62.50%> (-2.56%) ⬇️
jupyter_releaser/lib.py 74.28% <67.39%> (-3.46%) ⬇️
jupyter_releaser/npm.py 80.14% <70.37%> (-3.60%) ⬇️
jupyter_releaser/tests/test_cli.py 96.46% <76.92%> (-1.38%) ⬇️
jupyter_releaser/tee.py 82.05% <82.05%> (ø)
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.37% <100.00%> (+0.13%) ⬆️
jupyter_releaser/python.py 91.66% <100.00%> (+3.78%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10362d7...4aff85d. Read the comment docs.

@blink1073 blink1073 added the bug Something isn't working label Jul 19, 2021
@blink1073 blink1073 added this to the 0.2 milestone Jul 19, 2021
@blink1073 blink1073 merged commit 02cd108 into jupyter-server:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants