Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default for RH_IS_CHECK_RELEASE #70

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 16, 2021

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #70 (52da98a) into master (5b17742) will decrease coverage by 2.04%.
The diff coverage is 68.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   89.03%   86.99%   -2.05%     
==========================================
  Files          15       15              
  Lines        1697     1776      +79     
  Branches      198      215      +17     
==========================================
+ Hits         1511     1545      +34     
- Misses        118      151      +33     
- Partials       68       80      +12     
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/util.py 82.19% <37.50%> (-2.71%) ⬇️
jupyter_releaser/changelog.py 88.18% <62.50%> (-2.56%) ⬇️
jupyter_releaser/lib.py 74.70% <67.56%> (-3.04%) ⬇️
jupyter_releaser/npm.py 80.14% <70.37%> (-3.60%) ⬇️
jupyter_releaser/tests/test_cli.py 97.64% <91.66%> (-0.20%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.37% <100.00%> (+0.13%) ⬆️
jupyter_releaser/python.py 91.66% <100.00%> (+3.78%) ⬆️
jupyter_releaser/tests/conftest.py 98.50% <100.00%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba2fa2...52da98a. Read the comment docs.

@blink1073 blink1073 added the bug Something isn't working label Jul 16, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jul 16, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 685c968 into jupyter-server:master Jul 16, 2021
@jtpio jtpio deleted the default-env-var-value branch July 16, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants