Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Check Release Isolation #68

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 16, 2021

Start with a fresh git checkout after drafting the changelog, to prevent any other state from leaking between draft_changelog and draft_release. Extract just the changelog file and insert it into the new checkout directory.

See relevant failure here

@codecov-commenter
Copy link

Codecov Report

Merging #68 (be419f3) into master (84235d3) will decrease coverage by 0.84%.
The diff coverage is 5.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   87.83%   86.99%   -0.85%     
==========================================
  Files          15       15              
  Lines        1759     1776      +17     
  Branches      213      215       +2     
==========================================
  Hits         1545     1545              
- Misses        134      151      +17     
  Partials       80       80              
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6598291...be419f3. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 0.1 milestone Jul 16, 2021
@blink1073 blink1073 merged commit 16bd7ca into jupyter-server:master Jul 16, 2021
@jtpio jtpio deleted the check-release-diff branch July 16, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants