Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #59

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Fix typo #59

merged 1 commit into from
Jul 6, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jul 6, 2021

Follow up to #57

@blink1073 blink1073 added the bug Something isn't working label Jul 6, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jul 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #59 (17d230b) into master (5b17742) will decrease coverage by 1.06%.
The diff coverage is 77.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   89.03%   87.97%   -1.07%     
==========================================
  Files          15       15              
  Lines        1697     1754      +57     
  Branches      198      213      +15     
==========================================
+ Hits         1511     1543      +32     
- Misses        118      131      +13     
- Partials       68       80      +12     
Impacted Files Coverage Δ
jupyter_releaser/tests/test_functions.py 100.00% <ø> (ø)
jupyter_releaser/util.py 82.19% <37.50%> (-2.71%) ⬇️
jupyter_releaser/changelog.py 88.18% <62.50%> (-2.56%) ⬇️
jupyter_releaser/npm.py 80.14% <70.37%> (-3.60%) ⬇️
jupyter_releaser/lib.py 75.29% <71.87%> (-2.46%) ⬇️
jupyter_releaser/tests/test_cli.py 97.64% <91.66%> (-0.20%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.37% <100.00%> (+0.13%) ⬆️
jupyter_releaser/python.py 91.66% <100.00%> (+3.78%) ⬆️
jupyter_releaser/tests/conftest.py 98.50% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6199b4...17d230b. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 0c977a1 into jupyter-server:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants