Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle already published workspace packages #49

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

blink1073
Copy link
Contributor

Do not error when a given npm package exists if there are multiple npm packages. This covers the case of independently versioned lerna repositories where only a portion of the packages are being updated.

@blink1073 blink1073 added the bug Something isn't working label Jun 29, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jun 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #49 (2149097) into master (9129099) will decrease coverage by 0.23%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   88.51%   88.27%   -0.24%     
==========================================
  Files          15       15              
  Lines        1715     1740      +25     
  Branches      205      211       +6     
==========================================
+ Hits         1518     1536      +18     
- Misses        122      126       +4     
- Partials       75       78       +3     
Impacted Files Coverage Δ
jupyter_releaser/lib.py 75.29% <60.00%> (-1.07%) ⬇️
jupyter_releaser/tests/test_cli.py 97.64% <91.66%> (-0.20%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/npm.py 80.91% <100.00%> (+0.29%) ⬆️
jupyter_releaser/util.py 85.00% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8285f2d...2149097. Read the comment docs.

@blink1073 blink1073 merged commit f15fa65 into jupyter-server:master Jun 29, 2021
@blink1073 blink1073 deleted the fix-already-published branch June 29, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants