Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of GITHUB_OUTPUT #451

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 19, 2022

Attempt at fixing https://github.com/jupyter-server/jupyter_releaser/pull/444/files#r999693330

Otherwise it looks like a file named GITHUB_OUTPUT is being created on disk: jupyter/notebook#6579 (comment)

@jtpio jtpio added the bug Something isn't working label Oct 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 81.37% // Head: 81.37% // No change to project coverage 👍

Coverage data is based on head (7a43ba2) compared to base (4fc3095).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   81.37%   81.37%           
=======================================
  Files          20       20           
  Lines        2819     2819           
  Branches      361      361           
=======================================
  Hits         2294     2294           
  Misses        394      394           
  Partials      131      131           
Impacted Files Coverage Δ
jupyter_releaser/util.py 70.02% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, d'oh. Thanks!

@blink1073 blink1073 merged commit dfe1c9f into jupyter-server:main Oct 19, 2022
@jtpio jtpio deleted the github-output branch October 19, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants