Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify security handling #434

Merged
merged 5 commits into from
Oct 9, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #433

@blink1073 blink1073 added the enhancement New feature or request label Oct 8, 2022
@blink1073 blink1073 marked this pull request as draft October 8, 2022 21:31
@blink1073
Copy link
Contributor Author

Depends on a forthcoming fix to #421

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 81.53% // Head: 81.53% // No change to project coverage 👍

Coverage data is based on head (3b68f31) compared to base (de4f93b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          20       20           
  Lines        2805     2805           
  Branches      361      361           
=======================================
  Hits         2287     2287           
  Misses        390      390           
  Partials      128      128           
Impacted Files Coverage Δ
jupyter_releaser/util.py 71.63% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 marked this pull request as ready for review October 9, 2022 00:47
@blink1073 blink1073 enabled auto-merge (squash) October 9, 2022 00:49
@blink1073 blink1073 merged commit e231faf into jupyter-server:main Oct 9, 2022
@blink1073 blink1073 deleted the simplify-security branch October 9, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Security Handling
2 participants